feat(contract): removed panic error handling and added better error handling methods#184
Closed
AbuTuraab wants to merge 2 commits intorinafcode:mainfrom
Closed
feat(contract): removed panic error handling and added better error handling methods#184AbuTuraab wants to merge 2 commits intorinafcode:mainfrom
AbuTuraab wants to merge 2 commits intorinafcode:mainfrom
Conversation
|
Please update your PR title to follow the conventional commit format: Types: feat, fix, docs, style, refactor, test, chore, perf, ci, build, revert Examples:
See CONTRIBUTING.md for details. |
github-actions
bot
added
contract: insurance
contract: teachlink
documentation
|
@AbuTuraab Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
🎉 Welcome to TeachLink, @AbuTuraab! Thank you for your first contribution! A maintainer will review your PR soon. While you wait:
We appreciate your contribution to decentralized education! 🎓 |
AbuTuraab
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
📋 Description
🔗 Related Issue(s)
🎯 Type of Change
This PR replaces all unwrap(), expect(), and panic! uses in production contract code with explicit error handling and new error enums where needed. It also updates contract entrypoints to return Result where appropriate and adds targeted error-path tests across TeachLink, documentation, credential registry, and identity registry. Disabled test files were cleaned of unwrap() usage to align with the no-panic rule.